Conform GDCM to use CMAKE_*OUTPUT_DIRECTORY#5708
Open
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Open
Conform GDCM to use CMAKE_*OUTPUT_DIRECTORY#5708blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Infrastructure
blowekamp
requested review from
dzenanz,
hjmjohnson,
malaterre,
seanm and
thewtex
Member
Author
|
Comments are welcome before I make the PR to upstream GDCM. |
malaterre
approved these changes
Dec 26, 2025
Member
Author
|
GDCM PR made: malaterre/GDCM#201 |
Member
|
\azp run ITK.Windows |
Member
|
/azp run ITK.Windows |
blowekamp
force-pushed
the
gdcm_update_output_directory
branch
from
70d892b to
20c481f
Compare
Member
Author
|
@malaterre Can the PR in GDCM please be merged or shall we apply this patch just to ITK? |
Add GDCM support for modern CMAKE_*_OUTPUT_DIRECTORY variables. Removes setting legacy CMake cache variables. Internlly GDCM still uses the legacy names.
blowekamp
force-pushed
the
gdcm_update_output_directory
branch
from
20c481f to
d5cf8de
Compare
blowekamp
changed the title
Member
Author
|
As I recall this patch help support using ITK with FetchContent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GDCM support for modern CMAKE_*_OUTPUT_DIRECTORY variables. Removes setting legacy CMake cache variables.
Internally GDCM still uses the legacy names.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.